| commit | 035e720641f385e82c72b7b0a9e1d89e58cb5ed5 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Tue May 27 15:42:10 2025 -0400 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jun 02 13:27:41 2025 -0700 |
| tree | a1d61b0eb9fb4b1863a26a21e4f3d0b862a19672 | |
| parent | 797ba56186260ef66d186deb200bd324ec1516c8 [diff] |
Don't pass `parent` or `ad` to CRYPTO_EX_free We used to pass the parent object to callbacks, but this isn't safe. The object is in the middle of being destroyed, so the object's invariants won't hold. We can't remove the parameters, but pass in NULL instead. This also has the side effect of making it possible to manage CRYPTO_EX_DATA lifetime in its destructor, because we won't need to find some handle back to the parent object. It also means that defensively clearing fields in BIO destroy callbacks, while harmless, is more obviously unnecessary. Update-Note: CRYPTO_EX_free is no longer passed the parent object. We do not expect any callers to be impacted. Callers that were impacted probably had some object lifetime bug already. Fixed: 412707574 Change-Id: Idda889898a9eca3b59e3200ba1d5b4f2e62f2d37 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/79607 Reviewed-by: Adam Langley <agl@google.com> Auto-Submit: David Benjamin <davidben@google.com> Commit-Queue: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.
There are other files in this directory which might be helpful: